Skip to content

Conversation

@duncanhall
Copy link
Contributor

Fix for #226

Resubmitted after branching from the wrong place

Fix for swagger-api#226

Resubmitted after branching from the wrong place
@fehguy
Copy link
Contributor

fehguy commented Feb 5, 2015

If you look at the src structure and gulp tasks, you'll see that swagger-client is built from files under src/js. When running gulp build, your changes will be lost. Please modify the src contents

@duncanhall
Copy link
Contributor Author

@fehguy I'm not sure I follow? The changes were made to src/js/swagger-a.js. The swagger-client file has changes because I built and tested and then committed - and the lib folder is not .gitignored.

@fehguy
Copy link
Contributor

fehguy commented Feb 5, 2015

My bad, scrolled past that part of the commit. Sorry!

fehguy added a commit that referenced this pull request Feb 5, 2015
@fehguy fehguy merged commit f29b091 into swagger-api:develop_2.0 Feb 5, 2015
@duncanhall
Copy link
Contributor Author

Ha, no worries. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants