Setting basePath to '/' will point api calls to root. #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 10, 2013 19:41
…pend to root if its longer then 1 character
Author
|
Ping, any thoughts on this pull request? |
Contributor
|
Hi, this will fail if swagger-js is used in a headless fashion, such as with node.js. Wouldn't the best way to set the URL be in the javascript which configures swagger-ui? Or are you looking outside of swagger-ui, and going directly to the library? See here for what i mean: |
Contributor
|
please take a look at #92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you set the basePath of an api declaration to root ('/') a malformed url will be used (something like '//some/url'), which results in an error when you attempt to use the api.
In older versions of swagger this worked as expected, seems this functionality broke when the shred library started being used as it does some magic with parsing urls etc and results in different behaviors. We found this ability useful as it allows us to post swagger specs many different places with different hostnames & ports (i.e. local vs development vs production versions of the api) without having to change the basePath in the code.
This commit will detect if a url begins with a forward slash in the basePath and update it to point all api calls there.