Skip to content

Output curl URL in single quotes #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2015
Merged

Output curl URL in single quotes #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/types/operation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,7 +885,7 @@ Operation.prototype.asCurl = function (args1, args2) {
results.push('-d \'' + body.replace(/\'/g, '\\u0027') + '\'');
}

return 'curl ' + (results.join(' ')) + ' "' + obj.url + '"';
return 'curl ' + (results.join(' ')) + ' \'' + obj.url + '\'';
};

Operation.prototype.encodePathCollection = function (type, name, value) {
Expand Down
2 changes: 1 addition & 1 deletion test/compat/request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ describe('1.2 request operations', function () {
it('shows curl syntax', function () {
var curl = sample.pet.getPetById.asCurl({petId: 1});

expect(curl).toBe('curl -X GET --header \'Accept: application/json\' "http://localhost:8001/v1/api/pet/1"');
expect(curl).toBe('curl -X GET --header \'Accept: application/json\' \'http://localhost:8001/v1/api/pet/1\'');
});

it('generate a get request', function () {
Expand Down
8 changes: 4 additions & 4 deletions test/help.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ describe('help options', function () {
{summary: 'test operation'}, {}, {}, new auth.SwaggerAuthorizations());
var curl = op.asCurl({});

expect(curl).toBe('curl -X GET --header \'Accept: application/json\' "http://localhost/path"');
expect(curl).toBe('curl -X GET --header \'Accept: application/json\' \'http://localhost/path\'');
});

it('does not duplicate api_key in query param per #624', function () {
Expand All @@ -56,7 +56,7 @@ describe('help options', function () {
// repeat to ensure no change
curl = op.asCurl({});

expect(curl).toBe('curl -X GET --header \'Accept: application/json\' "http://localhost/path?api_key=abc123"');
expect(curl).toBe('curl -X GET --header \'Accept: application/json\' \'http://localhost/path?api_key=abc123\'');
});

it('prints a curl statement with headers', function () {
Expand Down Expand Up @@ -86,7 +86,7 @@ describe('help options', function () {
Authorization: 'Oauth:"test"'
});

expect(curl).toBe('curl -X GET --header \'Accept: application/json\' --header \'name: tony\' --header \'age: 42\' --header \'Authorization: Oauth:"test"\' "http://localhost/path"');
expect(curl).toBe('curl -X GET --header \'Accept: application/json\' --header \'name: tony\' --header \'age: 42\' --header \'Authorization: Oauth:"test"\' \'http://localhost/path\'');
});

it('prints a curl statement with custom content-type', function () {
Expand All @@ -96,6 +96,6 @@ describe('help options', function () {
responseContentType: 'application/xml'
});

expect(curl).toBe('curl -X GET --header \'Accept: application/xml\' "http://localhost/path"');
expect(curl).toBe('curl -X GET --header \'Accept: application/xml\' \'http://localhost/path\'');
});
});
6 changes: 3 additions & 3 deletions test/request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,21 +303,21 @@ describe('swagger request functions', function () {
var petApi = sample.pet;
var curl = petApi.addPet.asCurl({body: {id:10101}});

expect(curl).toBe('curl -X POST --header \'Content-Type: application/json\' --header \'Accept: application/json\' -d \'{"id":10101}\' "http://localhost:8000/v2/api/pet"');
expect(curl).toBe('curl -X POST --header \'Content-Type: application/json\' --header \'Accept: application/json\' -d \'{"id":10101}\' \'http://localhost:8000/v2/api/pet\'');
});

it('prints a curl post statement from a string', function () {
var petApi = sample.pet;
var curl = petApi.addPet.asCurl({body: '{"id":10101}'});

expect(curl).toBe('curl -X POST --header \'Content-Type: application/json\' --header \'Accept: application/json\' -d \'{"id":10101}\' "http://localhost:8000/v2/api/pet"');
expect(curl).toBe('curl -X POST --header \'Content-Type: application/json\' --header \'Accept: application/json\' -d \'{"id":10101}\' \'http://localhost:8000/v2/api/pet\'');
});

it('prints a curl post statement from a string containing a single quote', function () {
var petApi = sample.pet;
var curl = petApi.addPet.asCurl({body: '{"id":"foo\'bar"}'});

expect(curl).toBe('curl -X POST --header \'Content-Type: application/json\' --header \'Accept: application/json\' -d \'{"id":"foo\\u0027bar"}\' "http://localhost:8000/v2/api/pet"');
expect(curl).toBe('curl -X POST --header \'Content-Type: application/json\' --header \'Accept: application/json\' -d \'{"id":"foo\\u0027bar"}\' \'http://localhost:8000/v2/api/pet\'');
});

it('gets an server side 404, and verifies that the content-type in the response is correct, and different than one in the request', function (done) {
Expand Down