Skip to content

Conversation

@cesine
Copy link
Contributor

@cesine cesine commented Sep 13, 2016

Hi @fehguy we've been using swagger-client for about a year, its a great project! We noticed that our headers weren't being passed if they didn't match the case of the swagger spec.

I added some docs to #840 Nick's PR, let us know if there is anything else we can do to help get this merged in!

http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html

HTTP header fields, which include general-header (section 4.5), request-header (section 5.3), 
response-header (section 6.2), and entity-header (section 7.1) fields, follow the same generic format 
as that given in Section 3.1 of RFC 822 [9]. Each header field consists of a name followed by a 
colon (":") and the field value. Field names are case-insensitive.

@cesine cesine changed the title Headers should be case insenstive Headers should be case insensitive Sep 13, 2016
@fehguy
Copy link
Contributor

fehguy commented Sep 13, 2016

Hi I merged #840 so if you want to move any other tests or logic from this PR into a new one, I'd be happy to add.

@fehguy fehguy closed this Sep 13, 2016
@fehguy fehguy modified the milestone: v2.1.19 Sep 14, 2016
@cesine
Copy link
Contributor Author

cesine commented Sep 14, 2016

will do, its mostly just docs.

thanks @fehguy we really appreciated it!

@cesine
Copy link
Contributor Author

cesine commented Sep 17, 2016

@fehguy I squashed and rebased and pushed to this branch if you want to re-use this PR you can re-open it

@fehguy
Copy link
Contributor

fehguy commented Sep 20, 2016

@cesine looks like it won't let me reopen it :(

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants