Fix handling for jQuery response headers #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the way response headers are parsed when using the jQuery client. Enables the response headers to be properly viewed in the UI. Previous logic consistently returned an empty set of headers. Includes minor changes to allow the use of JS strict mode, at least for this function.
Contributor
Author
|
I hope this is the right place to put this. I submitted a similar request to the swagger-ui project and just realized it must be pulling from here. |
Contributor
|
yes, this is the right spot. I should have spotted that--good to have it in both places |
fehguy
added a commit
that referenced
this pull request
Jun 17, 2014
Fix handling for jQuery response headers
Contributor
Author
|
I put it in "dist" in the swagger-ui project. Should I submit it for the "lib" folder in swagger-ui as well? Will it get lost in the build? |
Contributor
|
best in both places |
Contributor
Author
|
OK, I set up a request for swagger-ui lib, too, so everything will be in sync. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the way response headers are parsed when using the jQuery client. Enables the response headers to be properly viewed in the UI. Previous logic consistently returned an empty set of headers. Includes minor changes to allow the use of JS strict mode, at least for this function.