Skip to content

PR #1019 broke defaults for integer parameters. #1029

@abassouk

Description

@abassouk

Hi al,
The PR #1019 broke default handling of integers and numbers. Specifically the lines at

}else if(schema.getType().equals("number")) {
Integer number = getInteger("default", node, false, location, result);
if (number != null) {
schema.setDefault(number);
}
}
}
are breaking both integer and floating-point defaults.

This should fix the issue:

            } else if(schema.getType().equals("integer")) {
                Integer number = getInteger("default", node, false, location, result);
                if (number != null) {
                    schema.setDefault(number);
                }
            } else if(schema.getType().equals("number")) {
                BigDecimal number = getBigDecimal("default", node, false, location, result);
                if (number != null) {
                    schema.setDefault(number);
                }
            }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions