Skip to content

Transform "void" response types #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 24, 2015
Merged

Transform "void" response types #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e2def1
Modifies conversion logic so that void response types will still result
gilbode Nov 11, 2015
44bbc4e
Fix test failures and augment tests for void response type.
gilbode Nov 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions ...es/swagger-compat-spec-parser/src/main/java/io/swagger/parser/SwaggerCompatConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,15 +437,13 @@ public Operation convertOperation(String tag, io.swagger.models.apideclaration.O

// default response type
Property responseProperty = propertyFromTypedObject(operation);
if (responseProperty != null) {
Response response = new Response()
.description("success")
.schema(responseProperty);
if (output.getResponses() == null) {
output.defaultResponse(response);
} else {
output.response(200, response);
}
Response response = new Response()
.description("success")
.schema(responseProperty);
if (output.getResponses() == null) {
output.defaultResponse(response);
} else if (responseProperty != null) {
output.response(200, response);
}

Map<String, List<AuthorizationScope>> auths = operation.getAuthorizations();
Expand Down
5 changes: 4 additions & 1 deletion ...es/swagger-compat-spec-parser/src/test/java/io/swagger/converter/LegacyConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,10 @@ public void testFixedProperties() throws IOException {
for (Response item : path.getPost().getResponses().values()) {
assertNull(item.getSchema());
}
assertNull(path.getDelete().getResponses());
assertEquals(path.getDelete().getResponses().size(), 1);
assertEquals(path.getDelete().getResponses().containsKey("default"), true);
assertEquals(path.getDelete().getResponses().get("default").getDescription(), "success");

final PathParameter id = (PathParameter) Iterables.find(path.getPatch().getParameters(),
new Predicate<Parameter>() {

Expand Down