fix schemas parse inconsistencies #1541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielCastro
added a commit
to GabrielCastro/swagger-parser
that referenced
this pull request
Mar 26, 2021
GabrielCastro
added a commit
to GabrielCastro/swagger-parser
that referenced
this pull request
Mar 26, 2021
GabrielCastro
force-pushed
the
fix/schema-parsing-inconsistencies
branch
from
989043a to
0484fc9
Compare
GabrielCastro
force-pushed
the
fix/schema-parsing-inconsistencies
branch
from
0484fc9 to
f8ade46
Compare
Author
Author
Author
|
It would be great to have either fix merged |
Contributor
|
thanks for the PR and adding the test! @GabrielCastro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schemas an of inline responses are parsed different from ones in definitions.
This manifests it's self as a bug in the generator: OpenAPITools/openapi-generator#9086 where
additionalPropertiesbehaves differently if it's in a response in-line or in definitions.