Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,11 @@ public static String computeDefinitionName(String ref) {
plausibleName = filePathElements[filePathElements.length - 1];

final String[] split = plausibleName.split("\\.");
// Fix for issue-1621
plausibleName = split[0];
for (int i = 1; i < split.length - 1; i++) {
plausibleName += "." + split[i];
}
}

return plausibleName;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,26 @@ public void testIssue1143(){
assertNotNull(result.getOpenAPI().getComponents().getSchemas().get("identificacion_usuario_aplicacion"));
}

@Test
public void testIssue1621() {
final ParseOptions parseOptions = new ParseOptions();
parseOptions.setResolve(true);
parseOptions.setResolveFully(true);
parseOptions.setResolveCombinators(false);
OpenAPIParser openAPIParser = new OpenAPIParser();
SwaggerParseResult swaggerParseResult = openAPIParser.readLocation("issue-1621/example.openapi.yaml", null, parseOptions);
assertEquals(0, swaggerParseResult.getMessages().size());
OpenAPI api = swaggerParseResult.getOpenAPI();
assertEquals("POST Example", api.getPaths()
.get("/example")
.getPost()
.getRequestBody()
.getContent()
.get("application/json")
.getSchema()
.getTitle());
}

@Test
public void testIssue749() {
ParseOptions options = new ParseOptions();
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
title: GET Example
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
openapi: 3.0.1
info:
title: Example OpenAPI spec
version: 0.0.1
paths:
'/example':
post:
requestBody:
content:
application/json:
schema:
$ref: '#/components/schemas/ExamplePost'
responses:
204:
description: No content
components:
schemas:
# Renaming this key from `Example` to `ExampleGet` stops the issue from occurring
# Removing this key stops the issue from occurring
Example:
$ref: example.get.yaml
ExamplePost:
$ref: example.post.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
title: POST Example