Skip to content

Json.pretty puts extensions in wrong place #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2017
Merged

Json.pretty puts extensions in wrong place #534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions modules/swagger-parser/src/test/java/io/swagger/parser/OpenAPIParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
package io.swagger.parser;

import io.swagger.oas.models.OpenAPI;
import io.swagger.parser.models.ParseOptions;
import io.swagger.parser.models.SwaggerParseResult;
import io.swagger.util.Json;
import org.junit.Test;

import static org.testng.Assert.assertEquals;
Expand Down Expand Up @@ -56,4 +58,29 @@ public void test30() {
assertNotNull(result.getOpenAPI());
assertEquals(result.getOpenAPI().getOpenapi(), "3.0.0-rc1");
}

@Test
public void testParsingPrettifiedExtensions() throws Exception {
String json =
"{\n" +
" \"openapi\": \"3.0.0\",\n" +
" \"x-some-extension\": \"some-value\"\n" +
"}";

SwaggerParseResult result = new OpenAPIParser().readContents(json, null, null);
assertNotNull(result);
OpenAPI openAPI = result.getOpenAPI();
assertNotNull(openAPI);
assertNotNull(openAPI.getExtensions());
assertEquals(openAPI.getExtensions().get("x-some-extension"), "some-value");

String prettyJson = Json.pretty(openAPI);

SwaggerParseResult prettyResult = new OpenAPIParser().readContents(prettyJson, null, null);
assertNotNull(prettyResult);
OpenAPI prettyOpenAPI = prettyResult.getOpenAPI();
assertNotNull(prettyOpenAPI);
assertNotNull(prettyOpenAPI.getExtensions());
assertEquals(prettyOpenAPI.getExtensions().get("x-some-extension"), "some-value");
}
}