Referring without components #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracekarina
reviewed
Nov 14, 2017
Contributor
There was a problem hiding this comment.
Hi! @joeljons, you are right, according to the spec the components tag is not required, so I think it is better to start changing the "true" to "false" in the deserializer and see what happens after that. We could validate the components object not being null in those places that we might missed. Thanks.
joeljons
force-pushed
the
refering-without-components
branch
from
b233388 to
7a29793
Compare
Contributor
Author
|
@gracekarina Do you want me to do that here in this PR? Or will you do it separately? |
Contributor
Author
|
@gracekarina It wasn't that many places so I went ahead and did it. |
Contributor
|
Thanks @joeljons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to how i interpret the spec the "components" object is not required. I wish it were! (Or at least default to an empty components object) I have had so some bugs where I assume components exists...
According to the deserializer it assumes it is required. (The
truemeans it is required)swagger-parser/modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/util/OpenAPIDeserializer.java
Line 137 in 647bfe2
This PR fixes a NPE in the resolver when the spec is missing the components tag and using external refs. I haven't checked, but I wouldn't be surprised if there are other cases of
openAPI.getComponents().getSomeSubObject()assuming components is not null. Maybe thinking about defaulting the root components to an empty object is worth thinking about...