Skip to content

adding maxItems and MinItems into ArrayModel deserializing - ticket#594 #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2018
Merged

adding maxItems and MinItems into ArrayModel deserializing - ticket#594 #619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions modules/swagger-parser/src/main/java/io/swagger/parser/util/SwaggerDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,6 +731,12 @@ public Model definition(ObjectNode node, String location, ParseResult result) {
am.items(items);
}

Integer maxItems = getInteger("maxItems", node, false, location, result);
am.setMaxItems(maxItems);

Integer minItems = getInteger("minItems", node, false, location, result);
am.setMinItems(minItems);

// extra keys
Set<String> keys = getKeys(node);
for(String key : keys) {
Expand Down
29 changes: 29 additions & 0 deletions modules/swagger-parser/src/test/java/io/swagger/parser/SwaggerParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -953,6 +953,35 @@ public void testIssue243() {
assertNotNull(result.getSwagger());
}

@Test
public void testIssue594() {
String yaml =
"swagger: '2.0'\n" +
"paths:\n" +
" /test:\n" +
" post:\n" +
" parameters:\n" +
" - name: body\n" +
" in: body\n" +
" description: Hello world\n" +
" schema:\n" +
" type: array\n" +
" minItems: 1\n" +
" maxItems: 1\n" +
" items: \n" +
" $ref: \"#/definitions/Pet\"\n" +
" responses:\n" +
" 200:\n" +
" description: 'OK'\n";
SwaggerDeserializationResult result = new SwaggerParser().readWithInfo(yaml);
assertNotNull(result.getSwagger());
ArrayModel schema = (ArrayModel)((BodyParameter)result.getSwagger().getPaths().get("/test").getPost().getParameters().get(0)).getSchema();
assertEquals(((RefProperty)schema.getItems()).get$ref(),"#/definitions/Pet");
assertNotNull(schema.getMaxItems());
assertNotNull(schema.getMinItems());

}

@Test
public void testIssue450() {
String desc = "An array of Pets";
Expand Down