Skip to content

refs swagger-api/swagger-core#2492 - remove allEmptyValue from body param #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2018
Merged

refs swagger-api/swagger-core#2492 - remove allEmptyValue from body param #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions modules/swagger-parser/src/main/java/io/swagger/parser/util/SwaggerDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,13 +640,8 @@ else if ("body".equals(value)) {
bp.setPattern(pat);
}

// allowEmptyValue
Boolean bl = getBoolean("allowEmptyValue", obj, false, location, result);
if(bl != null) {
bp.setAllowEmptyValue(bl);
}
// readOnly
bl = getBoolean("readOnly", obj, false, location, result);
Boolean bl = getBoolean("readOnly", obj, false, location, result);
if(bl != null) {
bp.setReadOnly(bl);
}
Expand Down
2 changes: 0 additions & 2 deletions modules/swagger-parser/src/test/java/io/swagger/parser/SwaggerParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,6 @@ public void testIssue360() {
assertTrue(stringBodyParameter instanceof BodyParameter);
BodyParameter sbp = (BodyParameter) stringBodyParameter;
assertTrue(sbp.getRequired());
assertTrue(sbp.getAllowEmptyValue());
assertEquals(sbp.getName(), "simple");

Model sbpModel = sbp.getSchema();
Expand All @@ -573,7 +572,6 @@ public void testIssue360() {
assertTrue(refBodyParameter instanceof BodyParameter);
BodyParameter ref = (BodyParameter) refBodyParameter;
assertTrue(ref.getRequired());
assertTrue(ref.getAllowEmptyValue());
assertEquals(ref.getName(), "simple");

Model refModel = ref.getSchema();
Expand Down
2 changes: 0 additions & 2 deletions modules/swagger-parser/src/test/resources/issue_360.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ paths:
- name: simple
in: body
required: true
allowEmptyValue: true
schema:
type: string
format: uuid
Expand All @@ -37,7 +36,6 @@ paths:
- name: simple
in: body
required: true
allowEmptyValue: true
schema:
$ref: '#/definitions/Pet'
definitions:
Expand Down