Fix for issue #676: convert integer elements of enum into the correct type #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR, @ackintosh! I'm sure @gracekarina will review it as soon as she can. One point though - would it be ok to ask to add support for other types as well? It might as well work for boolean (I've seen it) and number as well. |
Contributor
Author
|
Thanks for the comment! I'll add support later. |
Contributor
Author
|
@gracekarina Please review. 🙏 ✨ |
gracekarina
approved these changes
Apr 12, 2018
Contributor
gracekarina
left a comment
gracekarina
left a comment
There was a problem hiding this comment.
Hi @ackintosh, thanks for this PR!. merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #676 .