fixing relative references #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto OAS3-relative-resolving updating branch with 2.0
Do not read Info block if it does not exist
JehandadK
reviewed
Aug 2, 2018
|
|
||
| } else { | ||
| //its assumed to be a relative file ref | ||
| final Path pathToUse = parentDirectory.resolve(file).normalize(); |
Contributor
There was a problem hiding this comment.
Should this parentDirectory be the directory of where the file containing $ref exists or the directory of the main file which is read first by the Parser?
I am asking this because this seems to be the behavior of swagger-ui. And to make my swagger spec work with both I had to use links.
Contributor
Author
There was a problem hiding this comment.
is the directory where the file is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #727