Issue 740: OpenAPI v2 converter: java.lang.IllegalArgumentException with allOf and discriminatorr

[ymohdriz]

Hi team,

This PR is to solve the illegal argument exception in swagger converter as mentioned in the issue #740

Please review the PR and merge the same.

Thanks,
Mohammed

[jmini]

Thank you for looking into this topic.

I am not part of the team, but I guess a unit test to cover your changes would be great.

Have a look at V2ConverterTest. You will need to add a new file like issue-740.yaml in swagger-parser-v2-converter/src/test/resources and a new test case in V2ConverterTest.

The example (issue-740.yaml) should be as small as possible.
Your test should be red before your change and should be green after that.

Let me know if you need some help.

[jmini]

This change looks good to me.

@ymohdriz Thank you for this contribution.

I recommend you to add a unit test to this PR.

As an example, I have created one jmini@da64e41 in my fork on top of your commit ymohdriz@e4da496.

Can you please integrate this commit (or a similar one) in this Pull Request?

---

Note: When merging this PR I recommend "Squash and merge" because the intermediate commit in this branch are not really useful.

[ralphdoe]

Like @jmini pointed. I think it might be a good idea to add the test. Thanks for your contribution @ymohdriz

[ymohdriz]

Hi @ralphdoe,

Sure I will add the junit test for this issue. In future, I will commit the junits along with the fix.

Thanks,
Mohammed

[jmini]

This PR has still no junit tests...

@ymohdriz feel free to just add my commit to your PR or to add something similar.
Thank you in advance.

[jmini]

@ralphdoe, @gracekarina: I have opened an alternative PR to include the unit test discussed here and to solve the merge conflicts. => #777