Fix for 749 #752
Merged
Fix for 749 #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ref in external file in parameter with resolve option true
Contributor
|
This change looks good to me. @ymohdriz Thank you for this contribution. I recommend you to add a unit test to this PR. As an example, I have created one jmini@a2c4abe in my fork on top of your commit ymohdriz@94910e5. It is simple: I have extended a test specification I found in the repository with a parameter case as described in #749. Without your fix the test is red, with your fix it is green. Can you please integrate this commit (or a similar one) in this Pull Request? |
This was referenced Jul 10, 2018
jmini
added a commit
to OpenAPITools/swagger-parser
that referenced
this pull request
Jul 11, 2018
Port pull request swagger-api#752
Contributor
|
Hi @ymohdriz can you please add a unit test for it. Thanks! |
Contributor
Author
|
Hi @gracekarina , I have committed the junit tests fot this issue. Thanks a lot for your help @jmini Thanks, |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
This PR is to solve the issue '$ref in external file in parameter with resolve option true' as mentioned in #749
Please review the PR and merge the same.
Thanks,
Mohammed