Skip to content

Conversation

@zelark
Copy link
Contributor

@zelark zelark commented Oct 21, 2020

Description

I found that the problem was introduced in this merge.

Motivation and Context

Fixes #4825
Also I inverted the predicate for the sake of better maintenance. If any additional changes or tests required, please let me know.

How Has This Been Tested?

I did manual testing, put the configUrl and a remote config and loaded the page. Everything looks good, config loaded only once.

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai merged commit 50e5f65 into swagger-api:master Oct 22, 2020
@tim-lai
Copy link
Contributor

tim-lai commented Oct 22, 2020

@zelark Merged! Thanks for the contribution!

@zelark zelark deleted the fix-4825 branch October 22, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuration file downloaded 2 times when using configUrl

2 participants