fix: required properties #7206
Merged
fix: required properties #7206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schema required properties should not be treated like required: true. this lead to objects that requires properies beeing treated as required itself Signed-off-by: mathis-m <mathis.michel@outlook.de>
Contributor
|
@mathis-m Thanks for the PR! Can you add Cypress tests, one of each definition from the linked issues? |
Bumps [open](https://github.com/sindresorhus/open) from 8.0.6 to 8.0.7. - [Release notes](https://github.com/sindresorhus/open/releases) - [Commits](sindresorhus/open@v8.0.6...v8.0.7) Signed-off-by: dependabot[bot] <support@github.com>
…nd_yarn/open-8.0.7
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.2.7 to 2.2.8. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@2.2.7...2.2.8) Signed-off-by: dependabot[bot] <support@github.com>
…nd_yarn/dompurify-2.2.8
schema required properties should not be treated like required: true. this lead to objects that requires properies beeing treated as required itself Signed-off-by: mathis-m <mathis.michel@outlook.de>
…-ui into mathis-m-fix/required-properties
Contributor
|
@mathis-m PR merged! Thanks for the fix. Fyi, I added a test that covered both cited issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schema required properties should not be treated like required: true.
this lead to objects that requires properies beeing treated as required itself
Description
Motivation and Context
Fixes #7205
Fixes #7086
How Has This Been Tested?
browser
Screenshots (if appropriate):
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests