Some small tweaks #3244
Merged
Some small tweaks #3244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponelat
commented
Jun 15, 2017
src/core/plugins/spec/actions.js
Outdated
| } else if(op && pathName && method) { | ||
| req.operationId = fn.opId(op, pathName, method) | ||
| } | ||
| req.operationId = fn.opId(op, pathName, method) |
Contributor
Author
There was a problem hiding this comment.
TODO: @shockey need feedback on this.
I needed for reasons, but you've since fixed this upstream correct?
It pertains to executing requests based on operationId
Contributor
There was a problem hiding this comment.
@ponelat we do support finding the operation by one of three operationId strategies: https://github.com/swagger-api/swagger-js/blob/f00656ac9195dc13a4df4dcfab3634f1bfa218db/src/helpers.js#L44
ponelat
force-pushed
the
feature/small-tweaks
branch
from
c094d1f to
3681e86
Compare
Contributor
Author
|
Ping. |
Contributor
Author
|
@shockey as per policy change wrt to |
Contributor
|
@ponelat, correct 😄 |
shockey
approved these changes
Dec 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dist/ie:
{line, column} => {line, column, pointer}wherepointeris the string's index.