Streamline management of user-selected produces and consumes values (WIP)
#4137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shockey
commented
Jan 19, 2018
| } | ||
|
|
||
| componentWillReceiveProps(nextProps) { | ||
| const defaultContentType = "application/json" |
Contributor
Author
There was a problem hiding this comment.
Need to be sure to preserve this default
| } | ||
|
|
||
| if (producesValue === undefined) { | ||
| producesValue = produces && produces.size ? produces.first() : defaultContentType |
Contributor
Author
There was a problem hiding this comment.
Preserve this logic
src/core/plugins/spec/actions.js
Outdated
| export const CLEAR_REQUEST = "spec_clear_request" | ||
| export const CLEAR_VALIDATE_PARAMS = "spec_clear_validate_param" | ||
| export const UPDATE_OPERATION_VALUE = "spec_update_operation_value" | ||
| export const UPDATE_OPERATION_META_VALUE = "spec_UPDATE_OPERATION_META_VALUE" |
| return state.setIn( [ "mutatedRequests", path, method ], fromJSOrdered(req)) | ||
| }, | ||
|
|
||
| [UPDATE_OPERATION_VALUE]: (state, { payload: { path, value, key } }) => { |
Contributor
Author
There was a problem hiding this comment.
This needs to be documented as an internal API change in release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3998.
This is a 90% solution. The ContentType select components still transmit their default values, but the consumes/produces logic was removed from OperationContainer, so that logic only runs when it has to.