Skip to content

fix(oas3-editor-rendering): default to first server if current server becomes invalid #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 20, 2018
Merged

fix(oas3-editor-rendering): default to first server if current server becomes invalid #4139

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
350595f
Remove produces/consumes setter from OperationContainer
shockey Jan 19, 2018
2940e18
Store consumes/produces information in `meta` key
shockey Jan 19, 2018
99e3735
Migrate produces value state usage to `meta` key
shockey Jan 19, 2018
3be737a
use meta consumes data for isXml check
shockey Jan 19, 2018
2950e0f
Fix failing tests
shockey Jan 19, 2018
58eda41
normalize action name casing
shockey Jan 19, 2018
862a811
restore correct produces fallback value logic
shockey Jan 19, 2018
d56b238
default to first server if current server is invalid
shockey Jan 20, 2018
7d51dbe
Merge branch 'master' of github.com:swagger-api/swagger-ui
shockey Jan 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/core/plugins/oas3/components/servers.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ export default class Servers extends React.Component {
if(this.props.currentServer !== nextProps.currentServer) {
// Server has changed, we may need to set default values
let currentServerDefinition = servers
.find(v => v.get("url") === nextProps.currentServer) || OrderedMap()
.find(v => v.get("url") === nextProps.currentServer)

if(!currentServerDefinition) {
return this.setServer(servers.first().get("url"))
}

let currentServerVariableDefs = currentServerDefinition.get("variables") || OrderedMap()

Expand Down Expand Up @@ -90,6 +94,7 @@ export default class Servers extends React.Component {
getEffectiveServerValue
} = this.props


let currentServerDefinition = servers.find(v => v.get("url") === currentServer) || OrderedMap()

let currentServerVariableDefs = currentServerDefinition.get("variables") || OrderedMap()
Expand Down