Skip to content

Conversation

@maryscar
Copy link
Contributor

@maryscar maryscar commented Feb 6, 2018

Description

Fixes 2 common accessibility issues with font color contrast in the Models property section that effect visual accessibility.

Motivation and Context

Fixes 2 common accessibility issues with font color contrast in the Models property section. Suggested updates to styling.
#4201

How Has This Been Tested?

Ran npm tests.
Accessibility testing was completed using internal tools as well as Google Accessibility Extension (https://chrome.google.com/webstore/detail/accessibility-developer-t/fpkknkljclfencbdbgkenhalefipecmb) and aXe Accessibility Engine (https://www.deque.com/products/axe/).

Screenshots (if appropriate):

image

image

Types of changes

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shockey shockey merged commit 3d7a00c into swagger-api:master Feb 10, 2018
@shockey
Copy link
Contributor

shockey commented Feb 10, 2018

Thanks, @maryscar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants