Fix "Download File" link in response-body in Internet Explorer #4256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In internet explorer, the "Download File" button is shown as a link, but when clicked nothing happens. Right clicking the link and selecting Save as... will ignore file name, and only display the blob name. The file has the proper content though. Internet explorer uses window.navigator.msSaveOrOpenBlob to save files. Branching in this file, will allow proper functionality to the link, while having no breaking changes. This solves issues: swagger-api#3364 The error can be seen on this : http://swashbuckletest.azurewebsites.net/swagger/ui/index#/Image/Image_Put This way, the internet explorer little window in the middle of the bottom of the screen will pop up, with the proper filename.
Contributor
|
IE the best browser to download a real browser |
Contributor
Author
|
Our clients uses Internet Explorer sadly, so we need to support them too. |
Contributor
|
Looks like travis is acting up: Something like that happened to me, I just sent a commit to re-trigger the build in a few minutes and it completed sucessfully |
Update to triggger CI
Contributor
|
Now you do have a valid error:
|
Spacing
Contributor
Author
|
All good :) |
Contributor
Author
|
Whopsie, on the close :D |
Contributor
|
Strange, I still see some trailing tabs .... |
Removed whitespaces
Contributor
Author
|
There is no check for that it seems. Removed them. |
Contributor
|
AwesomO |
kovyfive
changed the title
shockey
suggested changes
Feb 27, 2018
| } | ||
|
|
||
| bodyEl = <div><a href={ href } download={ download }>{ "Download file" }</a></div> | ||
| if(window.navigator.msSaveOrOpenBlob) { |
Contributor
There was a problem hiding this comment.
Please refactor this to use the window wrapper instead of a direct window reference 😄
Imported window wrapper, and updated usage
Missing if update
Added extra check
Contributor
Author
|
Updated! |
Contributor
|
thanks, @kovyfive! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error can be seen on this :
http://swashbuckletest.azurewebsites.net/swagger/ui/index#/Image/Image_Put
When opened with Internet explorer, clicking the link does nothing.
Description
In internet explorer, the "Download File" button is shown as a link, but when clicked nothing happens.
Right clicking the link and selecting Save as... will ignore file name, and only display the blob name.
The file has the proper content though.
Internet explorer uses window.navigator.msSaveOrOpenBlob to save files.
Branching in this file, will allow proper functionality to the link, while having no breaking changes.
This way, the internet explorer little window in the middle of the bottom of the screen will pop up, with the proper filename.
Motivation and Context
The download link is not working in IE
Fixes #3364
How Has This Been Tested?
Built using NPM, added to WebApi project, built, opened Swagger, clicked on Download File link, and asserted the Save window appeared.
Screenshots (if appropriate):
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests