Skip to content

Conversation

@shockey
Copy link
Contributor

@shockey shockey commented Jul 27, 2018

Description

This PR ensures that numerical initial values are always converted to strings, which brings the initial values that make it into state into line with the values resulting from user input.

Motivation and Context

Fixes #4756.

How Has This Been Tested?

I added two new e2e tests.

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@shockey shockey changed the title fix(try-it-out): set initial values in ParameterRow fix(try-it-out): stringify numerical initial values in ParameterRow Jul 27, 2018
@shockey shockey merged commit 9553522 into master Jul 27, 2018
@shockey shockey deleted the bug/4756 branch August 28, 2018 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

try-it-out failed to submit a request when there's an enum field in formData.

2 participants