Skip to content

Conversation

@shockey
Copy link
Contributor

@shockey shockey commented Aug 4, 2018

Description

This PR adds a UI control for whether parameters with allowEmptyValue: true should be omitted or sent empty.

Motivation and Context

Fixes #1934, fixes #4223, and fixes #4587.

How Has This Been Tested?

I added unit and e2e tests where relevant 😄

Screenshots (if appropriate):

image

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@shockey shockey force-pushed the bug/allow-empty-value-controls branch from 732ab74 to 99371d7 Compare August 4, 2018 07:57
@shockey shockey merged commit 8729670 into master Aug 4, 2018
@heldersepu
Copy link
Contributor

heldersepu commented Aug 4, 2018

Since this change adds a new param I think the documentation should also change...
https://github.com/swagger-api/swagger-ui/blob/master/docs/usage/configuration.md

@shockey shockey deleted the bug/allow-empty-value-controls branch October 8, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants