Skip to content

perf(es/parser): Remove had_line_break_before_last #11200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2025
+6 −7
Merged

perf(es/parser): Remove had_line_break_before_last #11200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0413067
Remove had_line_break_before_last
CPunisher Oct 28, 2025
0471074
Create brave-penguins-shake.md
kdy1 Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/brave-penguins-shake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
swc_core: patch
swc_ecma_parser: patch
---

perf(es/parser): Remove `had_line_break_before_last`
7 changes: 0 additions & 7 deletions crates/swc_ecma_parser/src/lexer/state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ bitflags::bitflags! {
pub struct State {
/// if line break exists between previous token and new token?
pub had_line_break: bool,
/// if line break exists before last?
pub had_line_break_before_last: bool,
/// TODO: Remove this field.
is_first: bool,
pub next_regexp: Option<BytePos>,
Expand Down Expand Up @@ -204,7 +202,6 @@ impl crate::input::Tokens for Lexer<'_> {

self.state.set_token_type(token);
self.state.prev_hi = self.last_pos();
self.state.had_line_break_before_last = self.had_line_break_before_last();
}
// Attach span to token.
TokenAndSpan {
Expand Down Expand Up @@ -236,7 +233,6 @@ impl crate::input::Tokens for Lexer<'_> {

self.state.set_token_type(token);
self.state.prev_hi = self.last_pos();
self.state.had_line_break_before_last = self.had_line_break_before_last();
}
// Attach span to token.
TokenAndSpan {
Expand Down Expand Up @@ -360,7 +356,6 @@ impl crate::input::Tokens for Lexer<'_> {

self.state.set_token_type(token);
self.state.prev_hi = self.last_pos();
self.state.had_line_break_before_last = self.had_line_break_before_last();
}
// Attach span to token.
TokenAndSpan {
Expand Down Expand Up @@ -574,7 +569,6 @@ impl Iterator for Lexer<'_> {

self.state.set_token_type(token);
self.state.prev_hi = self.last_pos();
self.state.had_line_break_before_last = self.had_line_break_before_last();
// Attach span to token.
Some(TokenAndSpan {
token,
Expand All @@ -591,7 +585,6 @@ impl State {
pub fn new(start_pos: BytePos) -> Self {
State {
had_line_break: false,
had_line_break_before_last: false,
is_first: true,
next_regexp: None,
start: BytePos(0),
Expand Down
Loading