Skip to content
This repository was archived by the owner on Jan 3, 2018. It is now read-only.

Conversation

@ethanwhite
Copy link
Contributor

The current section on slicing is already relatively long. Since
we don't use strides anywhere else in the novice Python material
this removes them to avoid overwhelming the students with too much
detail too early.

The current section on slicing is already relatively long. Since
we don't use strides anywhere else in the novice Python material
this removes them to avoid overwhelming the students with too much
detail too early.
@jdblischak
Copy link
Contributor

@ethanwhite, could you please also regenerate novice/python/01-numpy.md by running make ipynb?

In general, I am in favor of removing material that is not essential for later in the lesson. The novice lessons contain a lot of content.

@ethanwhite
Copy link
Contributor Author

Done. I also made the same change to #683.

Is it normal for the markdown file to get substantially re-written in this process? There's a lot more diff than I expected.

@jdblischak
Copy link
Contributor

Is it normal for the markdown file to get substantially re-written in this process? There's a lot more diff than I expected.

I don't have much experience with creating the Markdown from ipynb notebooks (I am usually running make rmd). What appears to have happened is that when you ran make ipynb all the <p> tags were written on one line. Before they spanned multiple lines, e.g. see the raw original and new versions. I'm not sure what would cause this.

@gvwilson
Copy link
Contributor

The Markdown shouldn't change significantly, unless there have been
changes to templates, or to IPython, both of which are possible. This is
part of why I started the discussion (that went off the rails) about
whether we should use Plain Old Markdown for our notes (to simplify
diffing and merging, and minimize diffs). I'm going to re-start that
discussion...

@ethanwhite
Copy link
Contributor Author

Sounds good.

Since #683 has already gone in the major changes driven by whatever the differences are (I'm running IPython 2.1) have already gone in to the .md file, which is also preventing this from being auto-merged. Let's review this one on it's merits and then I can reroll if we want it to go in.

@rgaiacs
Copy link

rgaiacs commented Aug 30, 2014

Is it normal for the markdown file to get substantially re-written in this process? There's a lot more diff than I expected.

This happens due my mistake when I change template used by IPython Notebook. I hope this was fix by #652 (waiting review).

@ethanwhite
Copy link
Contributor Author

This has been re-rolled as #692.

@ethanwhite ethanwhite closed this Sep 4, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants