convert setPktInfo() to SocketOption #131
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently an issue on the main branch where constructing a UDP socket with IP6 fails every time on both Darwin and Linux:
Darin:
SocketError.failed(type: "SetOption", errno: 13, message: "Permission denied")Linux:
SocketError.failed(type: "SetPktInfoOption", errno: 22, message: "Invalid argument")While this PR does not fix the underlying issue, it moves the logic from
init()so sockets can opt in to setting the packet info allowing users to sidestep the issue.The
private func setPktInfo()has now been removed completely as some recent refactoring allows these options to be set via the existingprotocol SocketOption/setValue()API.Users now enable the packet info options like so:
Unit tests have been added to cover this case, and because it still fails when using IPv6 the tests currently assert expected failures.