Rust: callback based message handler #1070
Conversation
notoriaga
force-pushed
the
steve/link
branch
from
4e67b94 to
1a694f1
Compare
rust/sbp/src/link.rs
Outdated
| const MESSAGE_TYPES: &'static [u16] = &[T::MESSAGE_TYPE]; | ||
|
|
||
| fn from_sbp(msg: SBP) -> Self { | ||
| msg.try_into().unwrap() |
There was a problem hiding this comment.
Should this be fallible? At least should use .expect unless we never expect .unwrap to fail?
There was a problem hiding this comment.
It shouldn't ever fail, because from_sbp is only called after checking that the message was in MESSAGE_TYPES. So if you create a custom event and set the wrong messages types you could hit this error. So an expect is probably a good idea to make that more clear
There was a problem hiding this comment.
Agree, expect could point out that it should only happen if there's a programming error
There was a problem hiding this comment.
Well so actually this shouldn't ever error, this blanket impl makes all ConcreteMessages usable as events triggered by that messages type. So baring a logic error in the Link (i.e. sending an event to the wrong handler or something) this should never happen. Replaced the unwrap with a panic that will include the offending message just in case
rust/sbp/src/link.rs
Outdated
| self.stateless_link.clone() | ||
| } | ||
|
|
||
| pub fn send_state<M>(&self, state: &S, msg: M) -> bool |
There was a problem hiding this comment.
| pub fn send_state<M>(&self, state: &S, msg: M) -> bool | |
| pub fn send_with_state<M>(&self, state: &S, msg: M) -> bool |
Maybe?
rust/sbp/src/link.rs
Outdated
| let link = source.link(); | ||
| let count = RefCell::new(0); | ||
|
|
||
| link.register(|count: &RefCell<usize>, _: SBP| { |
There was a problem hiding this comment.
Should this test receiving an ObsMsg struct?
notoriaga
changed the title
No description provided.