make serde feature depend on serde-big-array #1190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notoriaga
approved these changes
Jul 14, 2022
samvrlewis
reviewed
Jul 14, 2022
| default = [] | ||
| async = ["futures", "dencode/async"] | ||
| json = ["serde", "serde_json", "serde-big-array", "base64"] | ||
| serde = ["dep:serde", "serde-big-array"] |
Contributor
There was a problem hiding this comment.
Ah, nice, I was wondering how you could do something like this
samvrlewis
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/devinfra
Makes
serdeandserde-big-arraygo together for theserdefeature, since some users only want to enableserdeand not thejsonfeature.API compatibility
Does this change introduce a API compatibility risk?
Should not, no messages are changed, but enables just the "serde" feature of the Rust library to be used in isolation from the "json" feature.
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
n/a
References
Jira
No Jira, but example breakage here: https://github.com/swift-nav/gnss-converters-private/runs/7347817014?check_suite_focus=true
Related PRs