Added sbp2json test #1198
Merged
Added sbp2json test #1198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-kong
requested review from
a team,
notoriaga and
silverjam
as code owners
notoriaga
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
fn test_sbp2json_*test for JsonEncoder (used in sbp2json) for serializing SBP messages into json strings.Tests for
sbp::json::CompactFormatterThis test also assumes the original
fn test_*passes, which does not usejsonfeature.As per last pull request: #1196
We added some more tests for
json2sbpwhich tests deserializing of raw json (using methods used in sbp2json) and checks the sbp fields.Basically TLDR:
fn test_json2sbp- tests from-fields is identical to sbp created via payload && contains all the fieldsfn test_sbp2json- tests sbp constructed from payload serialized into json is identical (basically roundtrip, json2sbp from-fields)JIRA Reference
https://swift-nav.atlassian.net/browse/DEVINFRA-821