Skip to content

Conversation

@adrian-kong
Copy link
Contributor

Add friendly_name method which trims out keywords

{
        "TRACKING": "TRK",
        "MEASUREMENT": "MEAS",
        "INDEX": "IDX",
        "NETWORK": "NET",
        "EPHEMERIS": "EPH",
        "_": " "
}

and 
"^MSG_"
"_GNSS$"

Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To statisfy SonarCloud let's add a simple unit test to Java that asserts that the friend name for each message is not empty.

@adrian-kong adrian-kong requested a review from silverjam December 9, 2022 11:44
Copy link
Contributor

@notoriaga notoriaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about possibly adding fn friendly_name(&self) -> &'static str to SbpMessage so you can directly fetch the friendly name, but that can be done later so LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants