Add support for murata scha634 to imu aux message #1286
Conversation
antrikshsrivastava
requested review from
a team,
notoriaga and
silverjam
as code owners
|
@antrikshsrivastava Is this ready for review? |
Not yet, it's not all working together yet, although this PR is unlikely to change much |
|
Converted to draft so I'm not notified that this is pending review, please click "Ready for review" once this is finalized |
silverjam
left a comment
silverjam
left a comment
There was a problem hiding this comment.
lgtm, please re-request review when this is ready for merge
jithk
left a comment
jithk
left a comment
There was a problem hiding this comment.
LGTM. Just curious - what caused the change in IMU_TYPE value from 2 to 4?
Because some of the other numbers are taken up by the Android and ICM42670 here: https://github.com/swift-nav/starling/blob/master/starling_util/src/sbp/unpackers.cc#L22 |
|
@silverjam how do we deal with the conflicts in this repo, I would think the PDF would just get overwritten? What about the RELEASE-VERSION change? |
Merge in master and resolve all conflicts with "theirs" then regenerate everything. |
|
@silverjam this is ready to merge in whenever, I can't merge it even though I have 1 approval |
|
Thanks @adrian-kong .. hmm it still says blocked for me: |
antrikshsrivastava
deleted the
antrikshsrivastava/esd-2529-add-murata-imu-to-sbp
branch
Description
@swift-nav/devinfra
API compatibility
Does this change introduce a API compatibility risk?
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
JIRA Reference
https://swift-nav.atlassian.net/browse/BOARD-XXXX