prep next release #no_auto_pr #1297
Conversation
adrian-kong
requested review from
a team,
notoriaga and
silverjam
as code owners
silverjam
left a comment
silverjam
left a comment
There was a problem hiding this comment.
Need to figure out the Python issues before we can merge
python/sbp/acquisition.py
Outdated
| from sbp.msg import SBP, SENDER_ID | ||
| from sbp.utils import fmt_repr, exclude_fields, walk_json_dict, containerize | ||
| from sbp.gnss import GnssSignal, GnssSignalDep | ||
| from sbp.gnss import CarrierPhase, GnssSignal, GnssSignalDep, GPSTime, GPSTimeDep, GPSTimeSec, SvId |
There was a problem hiding this comment.
Someone maybe manually edited these files to get them to pass CI? It looks like they are failing a pyflakes check:
________________________________ pyflakes-check ________________________________
/home/runner/work/libsbp/libsbp/python/sbp/acquisition.py:23: UnusedImport
'sbp.gnss.CarrierPhase' imported but unused
/home/runner/work/libsbp/libsbp/python/sbp/acquisition.py:23: UnusedImport
'sbp.gnss.GPSTime' imported but unused
/home/runner/work/libsbp/libsbp/python/sbp/acquisition.py:23: UnusedImport
'sbp.gnss.GPSTimeDep' imported but unused
/home/runner/work/libsbp/libsbp/python/sbp/acquisition.py:23: UnusedImport
'sbp.gnss.GPSTimeSec' imported but unused
/home/runner/work/libsbp/libsbp/python/sbp/acquisition.py:23: UnusedImport
'sbp.gnss.SvId' imported but unused
So, probably need to modify the Python template to ignore that check, or disable pyflakes. E.g. https://stackoverflow.com/a/10506715/749342 -- so add # NOQA to the end of the import line
There was a problem hiding this comment.
hmm NVM i think my tox is just broken actually...
make gen-python runs --remove-all-unused-imports, had some issues running tox it gets upgraded to tox>4 and returns 'import missing hookimpl',
instead this was generated running tox==3.12.1 which seems to not like the autoflake remove unused imports:
tox -e py --run-command="autoflake -i --remove-all-unused-imports -r python/sbp"
works fine running autoflake -i --remove-all-unused-imports -r python/sbp
adrian-kong
force-pushed
the
adrian/prep_next
branch
from
df5e6b2 to
e21a3d9
Compare
prep next release, not sure why
make pythoncreates all these files right now... (opening PR instead of pushing to master)also seems like java gradle needs to be downgraded or remove jacoco xml report