Modify to work with Rust's bindgen #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
FYI, going to merge this, seems low risk |
jbangelo
reviewed
Oct 25, 2019
| * `int` which can lead to portability issues between different platforms. | ||
| * \{ */ | ||
|
|
||
| #ifndef _RUSTC_BINDGEN_ |
Contributor
There was a problem hiding this comment.
Does bindgen define it's own s8 etc types? Do we actually need to not include the stdlib headers?
Contributor
Author
There was a problem hiding this comment.
I manually defined equivalent types to avoid the other includes that this generates. The lack of includes here is to limit the what bindgen tries to generate. Bindgen will attempt to generate bindings for everything it the .h-- so we want to avoid trying to generate bindings for everything in the c stdlib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows me to write an "entrypoint" header for bindgen so that I can automatically generate FFI bindings.