Added optional serialize feature to rust crate #747
Conversation
jbangelo
force-pushed
the
jbangelo/add-optional-serde-feature
branch
from
d3b7c8d to
620ecd3
Compare
|
One thing that came to mind was to add tests of the JSON serialization feature. The YAML tests contain JSON payload of the message, we could add tests that serialize a message object and make sure the resultant JSON is equivalent to the pre-generated JSON. |
|
@silverjam Agreed that it would significantly increase the size/complexity of this PR. Was just bringing it up in case anyone thought it would be prudent to include from the get go. I'll consider it a "nice to have" for the future. |
benjaminaltieri
left a comment
benjaminaltieri
left a comment
There was a problem hiding this comment.
look good to me. is there an example or test that showcases this new feature?
|
Merging as is. It looks like travis somehow missed the update. There's one failure in the travis build, but it's the pythong/haskell speed comparison which occasionally fails anyways. |
|
@benjaminaltieri There isn't an example at the moment. I'll have to resurrect my |
Added a compile time feature, called
serialize, which pulls in the base serde crate and derives all message types from the serde serialize and deserialize traits. In addition I updated the sbp crate to use the 2018 edition and fixed a few minor issues in the rust file templates.