Dzollo/python sender id whitelist #813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminaltieri
approved these changes
Jun 8, 2020
Contributor
benjaminaltieri
left a comment
benjaminaltieri
left a comment
There was a problem hiding this comment.
one small suggestion otherwise LGTM
python/sbp/client/framer.py
Outdated
| except Exception as exc: | ||
| warnings.warn("SBP dispatch error: %s" % (exc,)) | ||
| return msg | ||
| if (len(self._sender_id_filter) == 0 or sender in self._sender_id_filter): |
Contributor
There was a problem hiding this comment.
Suggested change
| if (len(self._sender_id_filter) == 0 or sender in self._sender_id_filter): | |
| if (not self._sender_id_filter or sender in self._sender_id_filter): |
Contributor
Author
There was a problem hiding this comment.
I could make that change; and agree it is a little clearer.
To do I would have to change the semantics of passing an empty list if not filter to passing None if no filter, and also change the default value to sender_id_filter=None for the keyword arg.
Contributor
Author
There was a problem hiding this comment.
Decided to rename the arg to include list and think that showing an empty list helps people know what to do should they choose to add a filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required for swift-nav/piksi_tools#1162