[HS-56] Add time offset message #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reimerix
requested review from
GuillaumeDec,
lloydmaza,
richarddeurloo and
scarcanague
GuillaumeDec
approved these changes
Jul 20, 2020
lloydmaza
reviewed
Jul 20, 2020
Contributor
lloydmaza
left a comment
lloydmaza
left a comment
There was a problem hiding this comment.
Looks good to me overall, however I may have missed a discussion addressing the situation in which multiple sensors in the same stream require GNSS time offsets. I didn't see any fields in the message itself which would identify any associated messages to which the offset applies - perhaps it's the intent of the flags field for a future date?
Contributor
Author
|
@lloydmaza If a device has multiple sensors connected, it should be using the same clock to timestamp them. I don't think we would need more than one time offset by sender. If a device happens to timestamp different sensors with different clocks, it could also send out these messages with different sender ids. @GuillaumeDec No other untracked files 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
MSG_GNSS_TIME_OFFSETto the SBP protocol. It contains the offset between a local time (unique to the sender ID emitting the messages) and the GNSS time scale.