[SO-6] Add SOLN_META message for Fuzed Wagon #832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This message will be part of the Fuzed Wagon, as per the new Starling Output Design. One field in the MSG_SOLN_META is called solution_inputs and is an array. Each element is effectively a u16, the first u8 identifies which sensor we're talking about and the other u8 has the sensor-specific contents. For the purpose of documenting these sensor-specific contents, dummy struct types, noted <Sensor>InputType are created, though not actually used as type. They're there, in a sense, to describe what is effectively a Union type, each variant being a specific sensor.
scarcanague
reviewed
Aug 6, 2020
Contributor
scarcanague
left a comment
scarcanague
left a comment
There was a problem hiding this comment.
A few comments but looks good
silverjam
suggested changes
Aug 6, 2020
silverjam
approved these changes
Aug 6, 2020
GuillaumeDec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://swift-nav.atlassian.net/browse/SO-6