cc: toolchain: add support for hermetic llvm on x86_64-darwin [BUILD-562] #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jungleraptor
changed the title
wwieclaw
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using the hermetic llvm toolchain on x86_64-darwin.
The configuration settings for darwin are mostly copied from: https://github.com/grailbio/bazel-toolchain/blob/master/toolchain/cc_toolchain_config.bzl
One major difference is we don't need to worry about supporting arbitrary versions of llvm, which simplifies things a little.
Also worth mentioning is on mac the toolchain is configured to use the system libc++, ld, and ar. This makes the toolchain less hermetic than the linux version. See the comments for the reasons why.
Known Issues
The clang-tidy aspect isn't currently working on x86_64-darwin. The llvm version of clang-tidy seems to have an issue finding the libc++ headers.
I've created a seperate ticket to track this issue, but I don't think it should be a blocker for getting this merged: https://swift-nav.atlassian.net/browse/BUILD-658
Testing
I also tested IDE integration (CLion), to make sure things like intellisense, debugging are still working as before.