add version to response #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
requested changes
Mar 26, 2020
| @@ -237,9 +239,27 @@ extension HTTPClient { | |||
| /// - status: Response HTTP status. | |||
| /// - headers: Reponse HTTP headers. | |||
| /// - body: Response body. | |||
| @available(*, deprecated, message: "please use init(host:status:version:headers:body:) instead") | |||
There was a problem hiding this comment.
there's a renamed: init(host:status:version:headers:body:) which gives a better error message and makes Xcode generate fixits automatically
weissi
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HTTP version to response struct. Closes #164
Motivation:
Servers are free to respond with different versions in some cases, clients need to have access to returned version.
Modifications:
Copy HTTP version from
.headpart toResponsestruct on init.Result:
Clients of the library now have access to returned HTTP version.