Use assertInEventLoop over assert(el.inEventLoop) #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
force-pushed
the
ff-use-assertInEventLoop
branch
from
996d710 to
592a851
Compare
Lukasa
approved these changes
Sep 8, 2020
|
Great catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
@weissi made me aware at multiple instances that
el.assertInEventLoop()should be used overassert(el.inEventLoop), since it ensures that the correct behavior is called forNIOTSEventLoops.Changes
Replace three instances of
assert(el.inEventLoop)withel.assertInEventLoop().