Skip to content

HTTPSchedulableRequest requires HTTPExecutableRequest #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2021
Merged

HTTPSchedulableRequest requires HTTPExecutableRequest #402

merged 1 commit into from
Jul 9, 2021

Conversation

fabianfett
Copy link
Member

Motivation

Scheduling a request on the new ConnectionPool will require a request to be schedulable and executable. In fact there should never be a request that is schedulable but not executable. For that reason the renamed HTTPSchedulableRequest depends on HTTPExecutableRequest.

Changes

  • Rename: HTTPExecutingRequest -> HTTPExecutableRequest
  • Rename: HTTPSchedulableRequest -> HTTPScheduledRequest
  • HTTPSchedulableRequest requires HTTPExecutableRequest

@fabianfett fabianfett added the 🔨 semver/patch No public API change. label Jul 9, 2021
@fabianfett fabianfett added this to the HTTP/2 support milestone Jul 9, 2021
@fabianfett fabianfett requested a review from Lukasa July 9, 2021 10:08
@Lukasa Lukasa merged commit 79db46a into swift-server:main Jul 9, 2021
@fabianfett fabianfett deleted the ff-protocol-restructure branch July 9, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
HTTP/2 support
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianfett @Lukasa