Skip to content

[HTTPConnectionPool] StateMachine has explicit function for HTTP1 connection close #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2021
Merged

[HTTPConnectionPool] StateMachine has explicit function for HTTP1 connection close #448

merged 1 commit into from
Oct 1, 2021

Conversation

fabianfett
Copy link
Member

Renamed generic function connectionClosed to specific http1ConnectionClose. We should have specific callbacks for http1 and http2.

@fabianfett fabianfett added the 🔨 semver/patch No public API change. label Oct 1, 2021
@fabianfett fabianfett added this to the HTTP/2 support milestone Oct 1, 2021
@fabianfett fabianfett requested review from Lukasa and dnadoba October 1, 2021 06:27
Lukasa
Lukasa approved these changes Oct 1, 2021
View reviewed changes
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very straightforward.

@fabianfett fabianfett merged commit a6ca288 into swift-server:main Oct 1, 2021
@fabianfett fabianfett deleted the ff-explicit-callout-http1ConnectionClosed branch April 12, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

@dnadoba dnadoba dnadoba approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
HTTP/2 support
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianfett @Lukasa @dnadoba