Skip to content

Conversation

karwa
Copy link
Contributor

@karwa karwa commented Nov 19, 2021

These 2 Foundation imports are not required. 🧹

@swift-server-bot
Copy link

Can one of the admins verify this patch?

6 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@dnadoba
Copy link
Collaborator

dnadoba commented Nov 19, 2021

@swift-server-bot test this please

1 similar comment
@fabianfett
Copy link
Member

@swift-server-bot test this please

Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks @karwa

@fabianfett fabianfett added the 🔨 semver/patch No public API change. label Nov 20, 2021
@fabianfett
Copy link
Member

@tomerd Apparently the trigger CI command doesn't work anymore... 😞

@Lukasa
Copy link
Collaborator

Lukasa commented Nov 22, 2021

@swift-server-bot test this please

@Lukasa
Copy link
Collaborator

Lukasa commented Nov 22, 2021

@fabianfett It does, just not for you on this repo. 😁

@Lukasa
Copy link
Collaborator

Lukasa commented Nov 22, 2021

Soundness is failing, but it isn't your fault, it's due to #489. We should be able to unblock this quickly.

@Lukasa Lukasa merged commit 8c48625 into swift-server:main Nov 22, 2021
@yim-lee
Copy link
Contributor

yim-lee commented Nov 22, 2021

Apparently the trigger CI command doesn't work anymore...

@fabianfett I fixed it (I think). PLMK if it still doesn't work for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants