Skip to content

Conversation

fabianfett
Copy link
Member

Motivation

Our current swiftformat version does not support async/await. Since we want to add support for async/await we must update swiftformat or disable it. I tried my very best to keep the number of changes as small as possible. I assume we want to stick with the new 0.48.8 for some time.

Changes

  • Update swiftformat to 0.48.8

Result

We can land async/await code.

@fabianfett fabianfett requested review from Lukasa and dnadoba November 25, 2021 08:46
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too bad, and we don't have a choice.

Copy link
Collaborator

@dnadoba dnadoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fabianfett fabianfett merged commit e502246 into swift-server:main Nov 25, 2021
@fabianfett fabianfett deleted the ff-swiftformat-0.48.8 branch November 25, 2021 09:15
@fabianfett fabianfett added the semver/none No version bump required. label Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants