Add XCTAsyncTest and XCTAssertThrowsError from gRPC Swift
#493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnadoba
force-pushed
the
dn-xctasynctest
branch
from
821d180 to
c124545
Compare
fabianfett
reviewed
Nov 25, 2021
glbrntt
reviewed
Nov 25, 2021
dnadoba
force-pushed
the
dn-xctasynctest
branch
from
fe74256 to
1ae73f4
Compare
Lukasa
approved these changes
Nov 25, 2021
|
@swift-server-bot test this please |
dnadoba
force-pushed
the
dn-xctasynctest
branch
from
58cfde5 to
db8b8a3
Compare
fabianfett
approved these changes
Nov 25, 2021
and move "XCTest+AsyncAwait.swift" from gRPC Swift into its own section
dnadoba
force-pushed
the
dn-xctasynctest
branch
from
db8b8a3 to
ae49e03
Compare
glbrntt
approved these changes
Nov 26, 2021
fabianfett
added
semver/none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to add async/await tests soon but the Linux implementation of XCTest doesn't have async-await support in Swift 5.5. In addition, our
generate_linux_tests.rbscript does not like async/await functions either. We therefore need a workaround to still be to test async/await code.Changes
XCTAsyncTestandXCTAssertThrowsErrorfrom https://raw.githubusercontent.com/grpc/grpc-swift/1.4.1-async-await/Tests/GRPCTests/AsyncAwaitSupport/XCTest%2BAsyncAwait.swift