Add ControlPlaneResponseDecoder #245
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
reviewed
Jan 6, 2022
| return .decoded(head) | ||
|
|
||
| case .contentLength(let length): | ||
| head.contentLength = length // TODO: This can crash |
tomerd
reviewed
Jan 6, 2022
| case 202: | ||
| return .accepted | ||
| case 400 ..< 600: | ||
| preconditionFailure("TODO: implement") |
tomerd
reviewed
Jan 6, 2022
| switch head.statusCode { | ||
| case 200: | ||
| guard let body = body else { | ||
| preconditionFailure("TODO: implement") |
tomerd
reviewed
Jan 6, 2022
| return status | ||
| } | ||
|
|
||
| private mutating func decodeCRLFTerminatedLine(from buffer: inout ByteBuffer) throws -> DecodeResult<ByteBuffer> { |
Contributor
There was a problem hiding this comment.
does nio offer any utils to parse line by line, I thought there was some Decoder for that?
tomerd
reviewed
Jan 6, 2022
| } | ||
|
|
||
| private mutating func decodeHeaderLine(from buffer: inout ByteBuffer) throws -> HeaderLineContent { | ||
| guard let colonIndex = buffer.readableBytesView.firstIndex(of: UInt8(ascii: ":")) else { |
tomerd
reviewed
Jan 6, 2022
| @discardableResult | ||
| mutating func decodeOptionalWhiteSpaceBeforeFieldValue(from buffer: inout ByteBuffer) throws -> Int { | ||
| let startIndex = buffer.readerIndex | ||
| guard let index = buffer.readableBytesView.firstIndex(where: { $0 != UInt8(ascii: " ") && $0 != UInt8(ascii: "\t") }) else { |
Contributor
There was a problem hiding this comment.
maybe worth defining consts for the UInt8 here and in other spots around the code
tomerd
reviewed
Jan 6, 2022
Contributor
tomerd
left a comment
tomerd
left a comment
There was a problem hiding this comment.
awesome. looks like some leftover TODOs?
tomerd
reviewed
Jan 6, 2022
| case .contentLength(let length): | ||
| head.contentLength = length // TODO: This can crash | ||
|
|
||
| case .contentType: |
Contributor
There was a problem hiding this comment.
we dont need to record that?
fabianfett
force-pushed
the
ff-response-decoder
branch
from
296cb92 to
41cd689
Compare
fabianfett
force-pushed
the
ff-response-decoder
branch
from
41cd689 to
c848509
Compare
Contributor
|
closing in inactive PRs, feel free to re-open if still relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ControlPlaneResponseDecoder to decode incoming HTTP responses.
Motivation:
We want to save allocations wherever possible. A big driver of allocations is the NIOHTTP1 HTTPResponseDecoder. The reason for this is: It can not be optimized for the lambda use case and allocates header string values that are not needed.
Modifications:
Result:
Faster control plane response decoding.