Skip to content

Conversation

@fabianfett
Copy link
Contributor

No description provided.

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start :)

Is docs/cold-start-procedure.png an omnigraffle or similar? If so, usually it's a good idea to commit that as well, in case there's going to be changes needed to it in the future etc. (even typos or rewording sometimes)

@fabianfett fabianfett force-pushed the ff-performance-docu branch from 124da0b to db0225d Compare May 28, 2020 18:42
@awslabs awslabs deleted a comment from ktoso May 28, 2020
@awslabs awslabs deleted a comment from ktoso May 28, 2020
@pokryfka
Copy link
Contributor

pokryfka commented Aug 14, 2020

@fabianfett please let me know if you'd like any X-Ray graphs to be generated.

If possible, I think it would be fair to mention performance of Foundation JSON encoder/decoder per #153

swift-aws-lambda-runtime makes it easy to change it if one knows about it.

For reference results of a cold run of the same function with and without Foundation, note:

  • shorter initialization (129 vs 168ms), the packages size is ~3MiB smaller without libFoundation.so which (uncompressed) is 11.8 MiB size; although the heaviest one is libicudataswift.so.65 with 28 MiB (!)
  • much faster DecodeIn(11.9 vs 173ms) and EncodeOut(0.1 vs 40.ms)
  • lambda handlers use encoders provided by lambda which is probably why the one using Foundation JSONEncoder is slower (can create subsegment for that to check it out); this example decodes and encodes very small payloads, the difference may be bigger if result is bigger
  • the difference is much less dramatic for warm runs

Screen Shot 2020-08-14 at 11 08 02

Screen Shot 2020-08-14 at 11 08 20

@tomerd
Copy link
Contributor

tomerd commented Oct 5, 2020

@fabianfett could you please update this PR to be against the main branch so we can delete the old master branch

@fabianfett fabianfett changed the base branch from master to main October 5, 2020 18:10
@tomerd
Copy link
Contributor

tomerd commented Jan 22, 2024

closing in inactive PRs, feel free to re-open if still relevant

@tomerd tomerd closed this Jan 22, 2024
@sebsto sebsto deleted the ff-performance-docu branch October 8, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants